get rid of usages of codepoints functions that are slow #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I’m not sure this is necessarily how we should be going about addressing this; the CodePoints functions were set as the default ones for a reason. Someone should at least investigate to see if we can improve performance there before giving up on the CodePoints functions entirely. |
Collaborator
Author
|
What could be done to improve performance using them? I couldn't find a good solution other than to reimplement combinators entirely. |
Collaborator
Author
|
Other solution would be for us to write all over the README that this doesn't do anything outside of CodeUnits and anyone who wants a CodePoints solution should submit a PR that works with an array of CodePoints or something. |
Collaborator
Author
|
Updated the README here to say that this works with code units, not code points |
Collaborator
Author
|
Closing as there is #44 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, this is all my fault. I forgot to try to purge all usages of CodePoints functions before and ran into this when one of my parsers became 100x slower.