bpo-42064: Remove stale extern declarations in sqlite3 headers (GH-26840)

Author: Erlend Egeberg Aasland

Modules/_sqlite/connection.h

@@ -98,8 +98,6 @@ typedef struct
     PyObject* NotSupportedError;
 } pysqlite_Connection;
 
-extern PyTypeObject *pysqlite_ConnectionType;
-
 int pysqlite_connection_register_cursor(pysqlite_Connection* connection, PyObject* cursor);
 int pysqlite_check_thread(pysqlite_Connection* self);
 int pysqlite_check_connection(pysqlite_Connection* con);

Modules/_sqlite/cursor.h

@@ -52,8 +52,6 @@ typedef struct
     PyObject* in_weakreflist; /* List of weak references */
 } pysqlite_Cursor;
 
-extern PyTypeObject *pysqlite_CursorType;
-
 int pysqlite_cursor_setup_types(PyObject *module);
 
 #define UNKNOWN (-1)

Modules/_sqlite/prepare_protocol.h

@@ -30,8 +30,6 @@ typedef struct
     PyObject_HEAD
 } pysqlite_PrepareProtocol;
 
-extern PyTypeObject *pysqlite_PrepareProtocolType;
-
 int pysqlite_prepare_protocol_setup_types(PyObject *module);
 
 #define UNKNOWN (-1)

Modules/_sqlite/row.h

@@ -33,8 +33,6 @@ typedef struct _Row
     PyObject* description;
 } pysqlite_Row;
 
-extern PyTypeObject *pysqlite_RowType;
-
 int pysqlite_row_setup_types(PyObject *module);
 
 #endif

Modules/_sqlite/statement.h

@@ -38,8 +38,6 @@ typedef struct
     PyObject* in_weakreflist; /* List of weak references */
 } pysqlite_Statement;
 
-extern PyTypeObject *pysqlite_StatementType;
-
 pysqlite_Statement *pysqlite_statement_create(pysqlite_Connection *connection, PyObject *sql);
 
 int pysqlite_statement_bind_parameter(pysqlite_Statement* self, int pos, PyObject* parameter);

Tools/c-analyzer/cpython/ignored.tsv

@@ -49,13 +49,6 @@ Modules/_io/_iomodule.h	-	_PyIO_str_write	-
 Modules/_io/_iomodule.h	-	_PyIO_empty_str	-
 Modules/_io/_iomodule.h	-	_PyIO_empty_bytes	-
 Modules/_multiprocessing/multiprocessing.h	-	_PyMp_SemLockType	-
-Modules/_sqlite/cache.h	-	pysqlite_NodeType	-
-Modules/_sqlite/cache.h	-	pysqlite_CacheType	-
-Modules/_sqlite/cursor.h	-	pysqlite_CursorType	-
-Modules/_sqlite/row.h	-	pysqlite_RowType	-
-Modules/_sqlite/prepare_protocol.h	-	pysqlite_PrepareProtocolType	-
-Modules/_sqlite/statement.h	-	pysqlite_StatementType	-
-Modules/_sqlite/connection.h	-	pysqlite_ConnectionType	-
 Modules/_sqlite/module.c	-	pysqlite_Error	-
 Modules/_sqlite/module.c	-	pysqlite_Warning	-
 Modules/_sqlite/module.c	-	pysqlite_InterfaceError	-
@@ -2372,13 +2365,6 @@ Modules/_tkinter.c	-	Tktt_Type	-
 Modules/xxlimited.c	-	Xxo_Type	-
 Modules/_decimal/_decimal.c	-	DecimalTuple	-
 Modules/_decimal/_decimal.c	-	PyDecSignalDict_Type	-
-Modules/_sqlite/connection.c	-	pysqlite_ConnectionType	-
-Modules/_sqlite/statement.c	-	pysqlite_StatementType	-
-Modules/_sqlite/cache.c	-	pysqlite_NodeType	-
-Modules/_sqlite/cache.c	-	pysqlite_CacheType	-
-Modules/_sqlite/row.c	-	pysqlite_RowType	-
-Modules/_sqlite/prepare_protocol.c	-	pysqlite_PrepareProtocolType	-
-Modules/_sqlite/cursor.c	-	pysqlite_CursorType	-
 
 # exception types  []
 Modules/_ctypes/_ctypes.c	-	PyExc_ArgError	-