Skip to content

Commit 44a3ee0

Browse files
ned-deilymiss-islington
authored andcommitted
bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297)
`BLDSHARED` needs to have both `LDFLAGS` and `LDFLAGS_NODIST`, not just `LDFLAGS_NODIST`; `PY_CORE_LDFLAGS` provides both. For example, as it stands now with just `LDFLAGS_NODIST`, macOS universal builds are broken as the necessary `-arch` flags are no longer passed to the standard library extension module link step from `setup.py` resulting in extension modules being single architecture only. https://bugs.python.org/issue35257
1 parent 284b787 commit 44a3ee0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎Makefile.pre.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ CONFINCLUDEPY= $(CONFINCLUDEDIR)/python$(LDVERSION)
153153
SHLIB_SUFFIX= @SHLIB_SUFFIX@
154154
EXT_SUFFIX= @EXT_SUFFIX@
155155
LDSHARED= @LDSHARED@ $(PY_LDFLAGS)
156-
BLDSHARED= @BLDSHARED@ $(PY_LDFLAGS_NODIST)
156+
BLDSHARED= @BLDSHARED@ $(PY_CORE_LDFLAGS)
157157
LDCXXSHARED= @LDCXXSHARED@
158158
DESTSHARED= $(BINLIBDEST)/lib-dynload
159159

0 commit comments

Comments
 (0)