cleanup the test.

skip rather than fail if we find unexpectedly high performance.

Author: gpshead

Lib/test/test_int.py

@@ -648,13 +648,11 @@ def test_denial_of_service_prevented_int_to_str(self):
             huge_decimal = str(huge_int)
         seconds_to_convert = get_time() - start
         self.assertEqual(len(huge_decimal), digits)
-        # Ensuring that we chose a slow enough conversion to time.
-        # Unlikely any CPU core will ever be faster than the assertion.
-        # It takes 0.10 seconds on a Zen based cloud VM in an opt build.
+        # Ensuring that we chose a slow enough conversion to measure.
+        # It takes 0.1 seconds on a Zen based cloud VM in an opt build.
         if seconds_to_convert < 0.005:
-            raise unittest.SkipTest(f'')
-        self.assertGreater(seconds_to_convert, 0.005,
-                           msg="'We're gonna need a bigger boat (int).'")
+            raise unittest.SkipTest('"slow" conversion took only '
+                                    f'{seconds_to_convert} seconds.')
 
         # We test with the limit almost at the size needed to check performance.
         # The performant limit check is slightly fuzzy, give it a some room.
@@ -685,18 +683,19 @@ def test_denial_of_service_prevented_str_to_int(self):
         if get_time() <= 0:  # some platforms like WASM lack process_time()
             get_time = time.monotonic
 
-        huge = '8'*200_000
-        with support.adjust_int_max_str_digits(200_000):
+        digits = 133700
+        huge = '8'*digits
+        with support.adjust_int_max_str_digits(digits):
             start = get_time()
             int(huge)
         seconds_to_convert = get_time() - start
-        # Ensuring that we chose a slow enough conversion to time.
-        # Unlikely any CPU core will ever be faster than the assertion.
-        # It takes 0.25 seconds on a Zen based cloud VM in an opt build.
-        self.assertGreater(seconds_to_convert, 0.02,
-                           msg="'We're gonna need a bigger boat (str).'")
+        # Ensuring that we chose a slow enough conversion to measure.
+        # It takes 0.1 seconds on a Zen based cloud VM in an opt build.
+        if seconds_to_convert < 0.005:
+            raise unittest.SkipTest('"slow" conversion took only '
+                                    f'{seconds_to_convert} seconds.')
 
-        with support.adjust_int_max_str_digits(200_000 - 1):
+        with support.adjust_int_max_str_digits(digits - 1):
             with self.assertRaises(ValueError) as err:
                 start = get_time()
                 int(huge)
@@ -709,7 +708,7 @@ def test_denial_of_service_prevented_str_to_int(self):
         extra_huge = '7'*1_200_000
         with self.assertRaises(ValueError) as err:
             start = get_time()
-            # If not limited, 8 seconds said Zen based cloud VM.
+            # If not limited, 8 seconds in the Zen based cloud VM.
             int(extra_huge)
         seconds_to_fail_extra_huge = get_time() - start
         self.assertIn('conversion', str(err.exception))