fix free-threaded builds

picnixz · picnixz · commit 9e0dd702401a · 2024-10-04T13:28:24.000+02:00
diff --git a/Modules/_cursesmodule.c b/Modules/_cursesmodule.c
@@ -4898,8 +4898,9 @@ curses_capi_free(void *capi)
 {
     assert(capi != NULL);
     void **capi_ptr = (void **)capi;
-    assert(capi_ptr[0] != NULL);
-    Py_DECREF(capi_ptr[0]); // decref curses window type
+    // In free-threaded builds, capi_ptr[0] may have been already cleared
+    // by curses_capi_capsule_destructor(), hence the use of Py_XDECREF().
+    Py_XDECREF(capi_ptr[0]); // decref curses window type
     PyMem_Free(capi_ptr);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -4898,8 +4898,9 @@ curses_capi_free(void *capi)`
`4898`	`4898`	`{`
`4899`	`4899`	`assert(capi != NULL);`
`4900`	`4900`	`void capi_ptr = (void )capi;`
`4901`		`- assert(capi_ptr[0] != NULL);`
`4902`		`- Py_DECREF(capi_ptr[0]); // decref curses window type`
	`4901`	`+ // In free-threaded builds, capi_ptr[0] may have been already cleared`
	`4902`	`+ // by curses_capi_capsule_destructor(), hence the use of Py_XDECREF().`
	`4903`	`+ Py_XDECREF(capi_ptr[0]); // decref curses window type`
`4903`	`4904`	`PyMem_Free(capi_ptr);`
`4904`	`4905`	`}`
`4905`	`4906`