Fix missing decref when storing and dict is detached but has been deleted

DinoV · DinoV · commit ac503e8ae657 · 2024-04-19T14:49:41.000-07:00
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -6805,6 +6805,9 @@ _PyObject_StoreInstanceAttribute(PyObject *obj, PyObject *name, PyObject *value)
             if (dict == NULL) {
                 return -1;
             }
+            int res = store_instance_attr_dict(obj, dict, name, value);
+            Py_DECREF(dict);
+            return res;
         }
         return store_instance_attr_dict(obj, dict, name, value);
     }

Original file line number	Diff line number	Diff line change
`@@ -6805,6 +6805,9 @@ _PyObject_StoreInstanceAttribute(PyObject obj, PyObject name, PyObject *value)`
`6805`	`6805`	`if (dict == NULL) {`
`6806`	`6806`	`return -1;`
`6807`	`6807`	`}`
	`6808`	`+ int res = store_instance_attr_dict(obj, dict, name, value);`
	`6809`	`+ Py_DECREF(dict);`
	`6810`	`+ return res;`
`6808`	`6811`	`}`
`6809`	`6812`	`return store_instance_attr_dict(obj, dict, name, value);`
`6810`	`6813`	`}`