bpo-39277: Fix PY_TIMEOUT_MAX cast in _threadmodule.c (GH-31195)

vstinner · web-flow · commit d3e53bc5321a · 2022-02-07T16:21:09.000+01:00
Cast PY_TIMEOUT_MAX to double, not to _PyTime_t.

Fix the clang warning:

Modules/_threadmodule.c:1648:26: warning: implicit conversion from
'_PyTime_t' (aka 'long') to 'double' changes value from
9223372036854775 to 9223372036854776
[-Wimplicit-const-int-float-conversion]
    double timeout_max = (_PyTime_t)PY_TIMEOUT_MAX * 1e-6;
                         ^~~~~~~~~~~~~~~~~~~~~~~~~ ~
diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c
@@ -1645,7 +1645,7 @@ thread_module_exec(PyObject *module)
     }
 
     // TIMEOUT_MAX
-    double timeout_max = (_PyTime_t)PY_TIMEOUT_MAX * 1e-6;
+    double timeout_max = (double)PY_TIMEOUT_MAX * 1e-6;
     double time_max = _PyTime_AsSecondsDouble(_PyTime_MAX);
     timeout_max = Py_MIN(timeout_max, time_max);
     // Round towards minus infinity

Original file line number	Diff line number	Diff line change
`@@ -1645,7 +1645,7 @@ thread_module_exec(PyObject *module)`
`1645`	`1645`	`}`
`1646`	`1646`
`1647`	`1647`	`// TIMEOUT_MAX`
`1648`		`- double timeout_max = (_PyTime_t)PY_TIMEOUT_MAX * 1e-6;`
	`1648`	`+ double timeout_max = (double)PY_TIMEOUT_MAX * 1e-6;`
`1649`	`1649`	`double time_max = _PyTime_AsSecondsDouble(_PyTime_MAX);`
`1650`	`1650`	`timeout_max = Py_MIN(timeout_max, time_max);`
`1651`	`1651`	`// Round towards minus infinity`