Skip to content

Commit f409c99

Browse files
bpo-32916: IDLE: Change str to code in pyparse (GH-5830)
Adjust tests and user modules to match. (cherry picked from commit c29c03a) Co-authored-by: Cheryl Sabella <[email protected]>
1 parent 8d9d4b5 commit f409c99

File tree

5 files changed

+103
-102
lines changed

5 files changed

+103
-102
lines changed

‎Lib/idlelib/editor.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1302,7 +1302,7 @@ def newline_and_indent_event(self, event):
13021302
startat = max(lno - context, 1)
13031303
startatindex = repr(startat) + ".0"
13041304
rawtext = text.get(startatindex, "insert")
1305-
y.set_str(rawtext)
1305+
y.set_code(rawtext)
13061306
bod = y.find_good_parse_start(
13071307
self.context_use_ps1,
13081308
self._build_char_in_string_func(startatindex))
@@ -1316,7 +1316,7 @@ def newline_and_indent_event(self, event):
13161316
else:
13171317
startatindex = "1.0"
13181318
rawtext = text.get(startatindex, "insert")
1319-
y.set_str(rawtext)
1319+
y.set_code(rawtext)
13201320
y.set_lo(0)
13211321

13221322
c = y.get_continuation_type()

‎Lib/idlelib/hyperparser.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def index2line(index):
4444
# at end. We add a space so that index won't be at end
4545
# of line, so that its status will be the same as the
4646
# char before it, if should.
47-
parser.set_str(text.get(startatindex, stopatindex)+' \n')
47+
parser.set_code(text.get(startatindex, stopatindex)+' \n')
4848
bod = parser.find_good_parse_start(
4949
editwin._build_char_in_string_func(startatindex))
5050
if bod is not None or startat == 1:
@@ -60,12 +60,12 @@ def index2line(index):
6060
# We add the newline because PyParse requires it. We add a
6161
# space so that index won't be at end of line, so that its
6262
# status will be the same as the char before it, if should.
63-
parser.set_str(text.get(startatindex, stopatindex)+' \n')
63+
parser.set_code(text.get(startatindex, stopatindex)+' \n')
6464
parser.set_lo(0)
6565

6666
# We want what the parser has, minus the last newline and space.
67-
self.rawtext = parser.str[:-2]
68-
# Parser.str apparently preserves the statement we are in, so
67+
self.rawtext = parser.code[:-2]
68+
# Parser.code apparently preserves the statement we are in, so
6969
# that stopatindex can be used to synchronize the string with
7070
# the text box indices.
7171
self.stopatindex = stopatindex

‎Lib/idlelib/idle_test/test_pyparse.py‎

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -62,32 +62,32 @@ def test_init(self):
6262
self.assertEqual(self.parser.indentwidth, 4)
6363
self.assertEqual(self.parser.tabwidth, 4)
6464

65-
def test_set_str(self):
65+
def test_set_code(self):
6666
eq = self.assertEqual
6767
p = self.parser
68-
setstr = p.set_str
68+
setcode = p.set_code
6969

7070
# Not empty and doesn't end with newline.
7171
with self.assertRaises(AssertionError):
72-
setstr('a')
72+
setcode('a')
7373

7474
tests = ('',
7575
'a\n')
7676

7777
for string in tests:
7878
with self.subTest(string=string):
79-
setstr(string)
80-
eq(p.str, string)
79+
setcode(string)
80+
eq(p.code, string)
8181
eq(p.study_level, 0)
8282

8383
def test_find_good_parse_start(self):
8484
eq = self.assertEqual
8585
p = self.parser
86-
setstr = p.set_str
86+
setcode = p.set_code
8787
start = p.find_good_parse_start
8888

8989
# Split def across lines.
90-
setstr('"""This is a module docstring"""\n'
90+
setcode('"""This is a module docstring"""\n'
9191
'class C():\n'
9292
' def __init__(self, a,\n'
9393
' b=True):\n'
@@ -117,7 +117,7 @@ def test_find_good_parse_start(self):
117117

118118
# Code without extra line break in def line - mostly returns the same
119119
# values.
120-
setstr('"""This is a module docstring"""\n'
120+
setcode('"""This is a module docstring"""\n'
121121
'class C():\n'
122122
' def __init__(self, a, b=True):\n'
123123
' pass\n'
@@ -138,19 +138,19 @@ def test_set_lo(self):
138138
' pass\n'
139139
)
140140
p = self.parser
141-
p.set_str(code)
141+
p.set_code(code)
142142

143143
# Previous character is not a newline.
144144
with self.assertRaises(AssertionError):
145145
p.set_lo(5)
146146

147-
# A value of 0 doesn't change self.str.
147+
# A value of 0 doesn't change self.code.
148148
p.set_lo(0)
149-
self.assertEqual(p.str, code)
149+
self.assertEqual(p.code, code)
150150

151151
# An index that is preceded by a newline.
152152
p.set_lo(44)
153-
self.assertEqual(p.str, code[44:])
153+
self.assertEqual(p.code, code[44:])
154154

155155
def test_tran(self):
156156
self.assertEqual('\t a([{b}])b"c\'d\n'.translate(self.parser._tran),
@@ -159,7 +159,7 @@ def test_tran(self):
159159
def test_study1(self):
160160
eq = self.assertEqual
161161
p = self.parser
162-
setstr = p.set_str
162+
setcode = p.set_code
163163
study = p._study1
164164

165165
(NONE, BACKSLASH, FIRST, NEXT, BRACKET) = range(5)
@@ -197,7 +197,7 @@ def test_study1(self):
197197

198198
for test in tests:
199199
with self.subTest(string=test.string):
200-
setstr(test.string) # resets study_level
200+
setcode(test.string) # resets study_level
201201
study()
202202
eq(p.study_level, 1)
203203
eq(p.goodlines, test.goodlines)
@@ -209,7 +209,7 @@ def test_study1(self):
209209
def test_get_continuation_type(self):
210210
eq = self.assertEqual
211211
p = self.parser
212-
setstr = p.set_str
212+
setcode = p.set_code
213213
gettype = p.get_continuation_type
214214

215215
(NONE, BACKSLASH, FIRST, NEXT, BRACKET) = range(5)
@@ -224,13 +224,13 @@ def test_get_continuation_type(self):
224224

225225
for test in tests:
226226
with self.subTest(string=test.string):
227-
setstr(test.string)
227+
setcode(test.string)
228228
eq(gettype(), test.continuation)
229229

230230
def test_study2(self):
231231
eq = self.assertEqual
232232
p = self.parser
233-
setstr = p.set_str
233+
setcode = p.set_code
234234
study = p._study2
235235

236236
TestInfo = namedtuple('TestInfo', ['string', 'start', 'end', 'lastch',
@@ -276,7 +276,7 @@ def test_study2(self):
276276

277277
for test in tests:
278278
with self.subTest(string=test.string):
279-
setstr(test.string)
279+
setcode(test.string)
280280
study()
281281
eq(p.study_level, 2)
282282
eq(p.stmt_start, test.start)
@@ -291,7 +291,7 @@ def test_study2(self):
291291
def test_get_num_lines_in_stmt(self):
292292
eq = self.assertEqual
293293
p = self.parser
294-
setstr = p.set_str
294+
setcode = p.set_code
295295
getlines = p.get_num_lines_in_stmt
296296

297297
TestInfo = namedtuple('TestInfo', ['string', 'lines'])
@@ -307,19 +307,19 @@ def test_get_num_lines_in_stmt(self):
307307
)
308308

309309
# Blank string doesn't have enough elements in goodlines.
310-
setstr('')
310+
setcode('')
311311
with self.assertRaises(IndexError):
312312
getlines()
313313

314314
for test in tests:
315315
with self.subTest(string=test.string):
316-
setstr(test.string)
316+
setcode(test.string)
317317
eq(getlines(), test.lines)
318318

319319
def test_compute_bracket_indent(self):
320320
eq = self.assertEqual
321321
p = self.parser
322-
setstr = p.set_str
322+
setcode = p.set_code
323323
indent = p.compute_bracket_indent
324324

325325
TestInfo = namedtuple('TestInfo', ['string', 'spaces'])
@@ -340,18 +340,18 @@ def test_compute_bracket_indent(self):
340340
)
341341

342342
# Must be C_BRACKET continuation type.
343-
setstr('def function1(self, a, b):\n')
343+
setcode('def function1(self, a, b):\n')
344344
with self.assertRaises(AssertionError):
345345
indent()
346346

347347
for test in tests:
348-
setstr(test.string)
348+
setcode(test.string)
349349
eq(indent(), test.spaces)
350350

351351
def test_compute_backslash_indent(self):
352352
eq = self.assertEqual
353353
p = self.parser
354-
setstr = p.set_str
354+
setcode = p.set_code
355355
indent = p.compute_backslash_indent
356356

357357
# Must be C_BACKSLASH continuation type.
@@ -361,7 +361,7 @@ def test_compute_backslash_indent(self):
361361
)
362362
for string in errors:
363363
with self.subTest(string=string):
364-
setstr(string)
364+
setcode(string)
365365
with self.assertRaises(AssertionError):
366366
indent()
367367

@@ -384,13 +384,13 @@ def test_compute_backslash_indent(self):
384384
)
385385
for test in tests:
386386
with self.subTest(string=test.string):
387-
setstr(test.string)
387+
setcode(test.string)
388388
eq(indent(), test.spaces)
389389

390390
def test_get_base_indent_string(self):
391391
eq = self.assertEqual
392392
p = self.parser
393-
setstr = p.set_str
393+
setcode = p.set_code
394394
baseindent = p.get_base_indent_string
395395

396396
TestInfo = namedtuple('TestInfo', ['string', 'indent'])
@@ -405,14 +405,14 @@ def test_get_base_indent_string(self):
405405

406406
for test in tests:
407407
with self.subTest(string=test.string):
408-
setstr(test.string)
408+
setcode(test.string)
409409
eq(baseindent(), test.indent)
410410

411411
def test_is_block_opener(self):
412412
yes = self.assertTrue
413413
no = self.assertFalse
414414
p = self.parser
415-
setstr = p.set_str
415+
setcode = p.set_code
416416
opener = p.is_block_opener
417417

418418
TestInfo = namedtuple('TestInfo', ['string', 'assert_'])
@@ -433,14 +433,14 @@ def test_is_block_opener(self):
433433

434434
for test in tests:
435435
with self.subTest(string=test.string):
436-
setstr(test.string)
436+
setcode(test.string)
437437
test.assert_(opener())
438438

439439
def test_is_block_closer(self):
440440
yes = self.assertTrue
441441
no = self.assertFalse
442442
p = self.parser
443-
setstr = p.set_str
443+
setcode = p.set_code
444444
closer = p.is_block_closer
445445

446446
TestInfo = namedtuple('TestInfo', ['string', 'assert_'])
@@ -462,13 +462,13 @@ def test_is_block_closer(self):
462462

463463
for test in tests:
464464
with self.subTest(string=test.string):
465-
setstr(test.string)
465+
setcode(test.string)
466466
test.assert_(closer())
467467

468468
def test_get_last_stmt_bracketing(self):
469469
eq = self.assertEqual
470470
p = self.parser
471-
setstr = p.set_str
471+
setcode = p.set_code
472472
bracketing = p.get_last_stmt_bracketing
473473

474474
TestInfo = namedtuple('TestInfo', ['string', 'bracket'])
@@ -489,7 +489,7 @@ def test_get_last_stmt_bracketing(self):
489489

490490
for test in tests:
491491
with self.subTest(string=test.string):
492-
setstr(test.string)
492+
setcode(test.string)
493493
eq(bracketing(), test.bracket)
494494

495495

0 commit comments

Comments
 (0)