Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 14, 2018

bpo-34279, bpo-35412: support.run_unittest() no longer raises
TestDidNotRun if a test result contains skipped tests. The
exception is now only raised if no test have been run and no test
have been skipped.
(cherry picked from commit 3a8f4fe)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue34279

bpo-34279, bpo-35412: support.run_unittest() no longer raises
TestDidNotRun if a test result contains skipped tests. The
exception is now only raised if no test have been run and no test
have been skipped.
(cherry picked from commit 3a8f4fe)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@vstinner
Copy link
Member

@ned-deily: Is the 3.6 branch currently blocked?

@ned-deily
Copy link
Member

ned-deily commented Dec 14, 2018

Yes, as I announced earlier. The 3.6 branch is now in security-fix mode with the exception of any 3.6.8 release blocker regressions.

https://discuss.python.org/t/3-7-2rc1-and-3-6-8rc1-cutoffs-ahead-last-3-6-x-bugfix-release/510/3
https://mail.python.org/pipermail/python-committers/2018-December/006474.html

@vstinner
Copy link
Member

@ned-deily it's hard for me to accept that I have to "abandon" (bugfixes in) 3.6 :-( I love this version! It's the version used for Python 3 in RHEL 8 beta!

@vstinner vstinner closed this Dec 14, 2018
@miss-islington miss-islington deleted the backport-3a8f4fe-3.6 branch December 14, 2018 17:02
@ned-deily
Copy link
Member

Yeah, 3.6 has been a big success, thanks to everyone’s hard work including yours. But it’s been in bug fix mode longer than any other 3.x release. Now we can focus on 3.7 bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants