Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 18, 2023

Since this function already has a modern alternative and was deprecated since 3.5, I've added a runtime warning for this function and slated it for removal in two versions (3.15) from now.


📚 Documentation preview 📚: https://cpython-previews--112236.org.readthedocs.build/

Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the details of code deprecation, but I improved the wording of the public announcements.

@sobolevn
Copy link
Member Author

@terryjreedy thank you!

@terryjreedy
Copy link
Member

terryjreedy commented Nov 18, 2023

The added code looks sensible but I would want someone more knowledgeable to check and a manual test of the notice.
EDIT: remove mistaken comment, and hide sobolevn's correct response thereto.

@sobolevn

This comment was marked as outdated.

Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phrasing nits in the news and whatnew entries

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexWaygood
Copy link
Member

Ah, I see @hugovk asked for some changes in #108901 (comment) -- I'll hold off merging for now :)

@Wulian233
Copy link
Contributor

I also recently found this issue, which may have been forgotten here, and needs to be removed in the 3.16 if added in 3.14

@vstinner
Copy link
Member

@sobolevn: What's the status of your PR?

@sobolevn
Copy link
Member Author

I guess that I will have to start everything over in 3.15 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants