-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-108901: Deprecate inspect.getcallargs and slate it for removal
#112236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Alex Waygood <[email protected]>
Misc/NEWS.d/next/Library/2023-11-18-17-01-45.gh-issue-108901.T3p5ie.rst
Outdated
Show resolved
Hide resolved
terryjreedy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with the details of code deprecation, but I improved the wording of the public announcements.
|
@terryjreedy thank you! |
|
The added code looks sensible but I would want someone more knowledgeable to check and a manual test of the notice. |
This comment was marked as outdated.
This comment was marked as outdated.
itamaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phrasing nits in the news and whatnew entries
Misc/NEWS.d/next/Library/2023-11-18-17-01-45.gh-issue-108901.T3p5ie.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Itamar Oren <[email protected]>
Misc/NEWS.d/next/Library/2023-11-18-17-01-45.gh-issue-108901.T3p5ie.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Ah, I see @hugovk asked for some changes in #108901 (comment) -- I'll hold off merging for now :) |
|
I also recently found this issue, which may have been forgotten here, and needs to be removed in the 3.16 if added in 3.14 |
|
@sobolevn: What's the status of your PR? |
|
I guess that I will have to start everything over in 3.15 :) |
Since this function already has a modern alternative and was deprecated since 3.5, I've added a runtime warning for this function and slated it for removal in two versions (3.15) from now.
inspectmodule, deprecate old incorrect APIs #108901📚 Documentation preview 📚: https://cpython-previews--112236.org.readthedocs.build/