Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jan 3, 2019

Currently it is decided if to use the srcentry in the copy_function by checking if the copy_function is copy() or copy2(). This will fail if the copy_function is a modified copy() or copy2() function. To control if the copy_function gets a srcentry or srcname parameter, added the use_srcentry parameter.

See bugtracker issue 35648.

https://bugs.python.org/issue35648

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@eamanu
Copy link
Contributor

eamanu commented Jan 3, 2019

You have conflicts hmmm try to update first your local repo

@ghost
Copy link
Author

ghost commented Jan 3, 2019

Oh, I didn't see the conflicts 😳

I will start a new PR with no conflicts, the signed CLA and the NEWS entry...

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants