-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-115231: fill __module__ for built-in staticmethods #115232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-115231: fill __module__ for built-in staticmethods #115232
Conversation
Co-authored-by: Nikita Sobolev <[email protected]>
8d2f05d to
be1c7ef
Compare
28eec6f to
c4dec10
Compare
|
See also #82062: we could fix that issue in a similar approach, using >>> int.to_bytes.__module__
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'method_descriptor' object has no attribute '__module__'. Did you mean: '__reduce__'? |
d29c90d to
386f383
Compare
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I would look what can we do with unbound instance methods and class methods. Because providing __module__ only for static methods loses purpose.
Hmm, I don't see ways to speedup this. Maybe solution is just to pay this price at time of access the
Why? Something meaningful is better than just |
Uh oh!
There was an error while loading. Please reload this page.