[3.7] bpo-36389: _PyObject_IsFreed() now also detects uninitialized memory (GH-12770) #12780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H-12770) Rename _PyMem_IsFreed() function to _PyMem_IsPtrFreed(). The function is now way more efficient, it became a simple comparison on integers, rather than a short loop. It detects also uninitialized bytes and "forbidden bytes" filled by debug hooks on memory allocators. Add unit tests on _PyObject_IsFreed(). (cherry picked from commit 2b00db6)
Member
Author
|
In master, I used a "static inline" function. To avoid any compilation issue in 3.7, I kept a regular function. |
Member
Author
|
Oh, it seems like some buildbots are unhappy with my change in the master branch :-/ |
Member
Author
|
I close this PR. I will redo it once my following fix will be merged in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename _PyMem_IsFreed() function to _PyMem_IsPtrFreed(). The function
is now way more efficient, it became a simple comparison on integers,
rather than a short loop. It detects also uninitialized bytes and
"forbidden bytes" filled by debug hooks on memory allocators.
Add unit tests on _PyObject_IsFreed().
(cherry picked from commit 2b00db6)
https://bugs.python.org/issue36389