Skip to content

gh-129343: Add _repr method to named tuples #129353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnslavik wants to merge 1 commit into from
Closed

gh-129343: Add _repr method to named tuples #129353

johnslavik wants to merge 1 commit into from

Conversation

@johnslavik
Copy link
Contributor

@johnslavik johnslavik commented Jan 27, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 27, 2025
Closed
@johnslavik
Copy link
Contributor Author

johnslavik commented Jan 27, 2025

Concern to address: duplication of repr docs in the help string.

My idea: change the __repr__ docstring to a different one, underlining its overridability.

@johnslavik
Copy link
Contributor Author

johnslavik commented Jan 27, 2025

This PR assumes super() works in typing.NamedTuple subclasses, so it is blocked by #129352.

@rhettinger rhettinger self-assigned this Jan 28, 2025
@rhettinger rhettinger closed this Feb 3, 2025
@johnslavik johnslavik deleted the add-namedtuple-_repr branch February 3, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

@rhettinger rhettinger

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnslavik @rhettinger