bpo-26835: Add file-sealing ops to fcntl #13015
Conversation
| @@ -0,0 +1 @@ | |||
| fcntl now has File Sealing operations. No newline at end of file | |||
There was a problem hiding this comment.
Please, use markdown formatting for fcntl (:func:fcntl.fcntl).
| and Windows use this to properly terminate scripts in interactive sessions. | ||
| (Contributed by Google via Gregory P. Smith in :issue:`1054041`.) | ||
|
|
||
| * fcntl now has File Sealing operations.(Contributed by Joannah Nanjekye |
There was a problem hiding this comment.
Please, use markdown formatting for fcntl (:func:fcntl.fcntl).
There was a problem hiding this comment.
What about write the final . after "()" And don't write the . inside the parenthesis. Like this:
fcntl now has File Sealing operations (Contributed by Joannah Nanjekye in :issue:`26835`).
There was a problem hiding this comment.
Conform to the style used in other entries.
|
I think we need tests for these options, taking into account that some of them are hardcoded. |
| /* | ||
| * Set/Get seals | ||
| */ | ||
| #define F_ADD_SEALS (F_LINUX_SPECIFIC_BASE + 9) |
There was a problem hiding this comment.
Rather of defining constants with fake values, it is better to add them conditionally, as other platform-specific constants. They should not be present on non-Linux and on old Linux.
| and Windows use this to properly terminate scripts in interactive sessions. | ||
| (Contributed by Google via Gregory P. Smith in :issue:`1054041`.) | ||
|
|
||
| * fcntl now has File Sealing operations.(Contributed by Joannah Nanjekye |
There was a problem hiding this comment.
Conform to the style used in other entries.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Superseded by #13694. @nanjekyejoannah, thank you for your work on this. |
|
Thanks @tiran , Also next time it is good to ping author before opening replacement PR. It is just that some authors may feel bad for the time they Invested :) |
7 participants
I have added File Sealing operations to fnctl .
https://bugs.python.org/issue26835