Skip to content

bpo-36921: Deprecate @coroutine and yield from in asyncio #13334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asvetlov wants to merge 10 commits into from
Closed

bpo-36921: Deprecate @coroutine and yield from in asyncio #13334

asvetlov wants to merge 10 commits into from

Conversation

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented May 15, 2019 •
edited by bedevere-bot
Loading

In favor of async def and await

https://bugs.python.org/issue36921

@asvetlov asvetlov requested a review from 1st1 as a code owner May 15, 2019 08:34
matrixise
matrixise reviewed May 15, 2019
View reviewed changes
Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asvetlov nice PR ;-) but maybe use coroutine and future instead of coro and fut...

Lib/asyncio/coroutines.py
return f'<{self.__class__.__name__} {coro_repr}>'

def __iter__(self):
warnings.warn("yield from coro is deprecated, please use await coro instead",
Copy link
Member

@matrixise matrixise May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use coroutine instead of the coro because I think coro is not defined in the glossary.

yield from coroutine
await coroutine

Copy link
Contributor Author

@asvetlov asvetlov May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe.
On the other hand, I don't like too long messages.
Usually, I rely on @1st1 judgment for texts :)

Lib/asyncio/futures.py

__iter__ = __await__ # make compatible with 'yield from'.
def __iter__(self):
warnings.warn("yield from fut is deprecated, please use await fut instead",
Copy link
Member

@matrixise matrixise May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wording
yield from future and await future

tirkarthi
tirkarthi reviewed May 15, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some deprecation warnings with ./python.exe -Werror -m test -j4 . test_typing also has a usage of @coroutine

cpython/Lib/test/test_typing.py

Line 1711 in 5eb8b07

@asyncio.coroutine
. I used a non-ssl build so I might have missed something.

test_asyncio

======================================================================
ERROR: test_handle_repr (test.test_asyncio.test_events.HandleTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_events.py", line 2140, in test_handle_repr
    cb = asyncio.coroutine(noop)
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/asyncio/coroutines.py", line 114, in coroutine
    warnings.warn("@coroutine decorator is deprecated, "
DeprecationWarning: @coroutine decorator is deprecated, please use async def function instead

======================================================================
ERROR: test_iter (test.test_asyncio.test_futures.CFutureTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 376, in test_iter
    test()
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 373, in test
    arg1, arg2 = coro()
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 370, in coro
    yield from fut
DeprecationWarning: yield from fut is deprecated, please use await fut instead

======================================================================
ERROR: test_uninitialized (test.test_asyncio.test_futures.CFutureTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 196, in test_uninitialized
    iter(fut)
DeprecationWarning: yield from fut is deprecated, please use await fut instead

======================================================================
ERROR: test_iter (test.test_asyncio.test_futures.CSubFutureTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 376, in test_iter
    test()
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 373, in test
    arg1, arg2 = coro()
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 370, in coro
    yield from fut
DeprecationWarning: yield from fut is deprecated, please use await fut instead

======================================================================
ERROR: test_uninitialized (test.test_asyncio.test_futures.CSubFutureTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 196, in test_uninitialized
    iter(fut)
DeprecationWarning: yield from fut is deprecated, please use await fut instead

======================================================================
ERROR: test_iter (test.test_asyncio.test_futures.PyFutureTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 376, in test_iter
    test()
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 373, in test
    arg1, arg2 = coro()
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 370, in coro
    yield from fut
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/asyncio/futures.py", line 264, in __iter__
    warnings.warn("yield from fut is deprecated, please use await fut instead",
DeprecationWarning: yield from fut is deprecated, please use await fut instead

======================================================================
ERROR: test_uninitialized (test.test_asyncio.test_futures.PyFutureTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_futures.py", line 196, in test_uninitialized
    iter(fut)
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/asyncio/futures.py", line 264, in __iter__
    warnings.warn("yield from fut is deprecated, please use await fut instead",
DeprecationWarning: yield from fut is deprecated, please use await fut instead

======================================================================
ERROR: test_exception_waiter (test.test_asyncio.test_streams.StreamTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_asyncio/test_streams.py", line 592, in test_exception_waiter
    def set_err():
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/asyncio/coroutines.py", line 114, in coroutine
    warnings.warn("@coroutine decorator is deprecated, "
DeprecationWarning: @coroutine decorator is deprecated, please use async def function instead

----------------------------------------------------------------------
Ran 2071 tests in 69.820s

FAILED (errors=8, skipped=102)

@asvetlov
Copy link
Contributor Author

asvetlov commented May 15, 2019

@tirkarthi thanks! I'll take a look

@asvetlov
Copy link
Contributor Author

asvetlov commented May 15, 2019

Well, the change is too aggressive.
Better to deprecate @coroutine only but allow yield from fut and yield from task.
It makes the same effect but much easier

@asvetlov asvetlov closed this May 15, 2019
@asvetlov asvetlov deleted the deprecate-yield-from-in-asyncio branch September 12, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise left review comments

@tirkarthi tirkarthi tirkarthi left review comments

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asvetlov @matrixise @tirkarthi @the-knights-who-say-ni @bedevere-bot