gh-81087: Add str.dedent and cache it at compile time #13445
Conversation
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
missing: A documentation update documenting the new str.dedent method.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@remilapeyre, if your changes are ready to be reviewed again, please add a PR-level comment as requested by @bedevere-bot. Thanks! |
|
@csabella, sorry, I have made the requested changes; please review again |
|
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
|
@remilapeyre, please resolve the merge conflicts. Thank you! |
|
Hi @csabella, it should be good now. There is a lot of PendingDeprecationWarnings in the tests. I'm not sure what I should do, should I fix all calls or let them as is for now? |
terryjreedy
removed request for
1st1,
asvetlov,
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan,
pablogsal,
terryjreedy and
warsaw
|
One thing I think would help this PR is not updating so many Changing those to use the new |
|
@remilapeyre Would you like to untangle the code changes here from updating existing usages of |
|
Hi @ammaraskar I don't mind either as I was seriously lacking time to take care of this the past few months. I'm trying to find half a day a week to work on CPython again so I should come back to this PR in a few days. |
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Requesting changes as per above; we should separate the implementation of the feature from its use elsewhere in the codebase
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
terryjreedy
changed the title
| 'file': 'sidebar', | ||
| 'kwds': {}, | ||
| 'msg': textwrap.dedent("""\ | ||
| 'msg': """\ |
There was a problem hiding this comment.
I don't like having '.dedent moved from here to the end 16 lines down.
In any case, I want both idlelib changes removed from this PR to avoid gratuitous differences between versions.
|
Closing this, it requires a PEP and is now quite a bit out of date. |
12 participants
Uh oh!
There was an error while loading. Please reload this page.