Skip to content

gh-139003: Use frozenset for module level attributes in _pyrepl.utils #139004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eendebakpt wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-139003: Use frozenset for module level attributes in _pyrepl.utils #139004

eendebakpt wants to merge 2 commits into from

Conversation

@eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Sep 16, 2025 •
edited by bedevere-app bot
Loading

Improve performance by using a frozenset instead of a set for module level attributes. Identified in #138931 (comment).

@bedevere-app bedevere-app bot mentioned this pull request Sep 16, 2025
Open
efimov-mikhail
efimov-mikhail approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@efimov-mikhail efimov-mikhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efimov-mikhail efimov-mikhail efimov-mikhail approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eendebakpt @efimov-mikhail @StanFromIreland