bpo-37251: MagicMock with function spec used as a spec in mock.patch should return a MagicMock #14117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangrisano
approved these changes
Jun 15, 2019
Member
Author
|
Closing in favor of #15830 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MagicMock with a function spec will have
__code__object. When it is used a spec tomock.patchthen__code__object which is a MagicMock is used to detect if it's a coroutine.MagicMock.__code__ & 128returns another MagicMock which is evaluated to True and returned as a coroutine incorrectly. Hence check__code__to be aCodeTypeto make sure MagicMock with__code__is not detected as coroutine.https://bugs.python.org/issue37251