gh-141571: Avoid redundant early _set_color() call in HelpFormatter #141611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
reviewed
Nov 16, 2025
| width -= 2 | ||
|
|
||
| self._set_color(color) | ||
| self._color = color |
Contributor
There was a problem hiding this comment.
I don't understand where is this used.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review!
You're right — after checking the code path again, this self._color assignment is not actually used anywhere before _get_formatter() runs. I will check and i will report if i found the real issue
Member
|
Why are you re-opening the same PR with same (incorrect) fix? please only open a PR when you've investigated and fixed the behavior. If you do not have a fix, please close the PR yourself (or I'll do so in a few days) |
Member
|
Closing because this was fixed by another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a redundant color initialization in argparse.HelpFormatter.
Currently,
HelpFormatter.__init__()calls_set_color(color)immediately,and then
_get_formatter()calls_set_color(self.color)again.This results in duplicate environment checks and redundant calls to
_colorize.can_colorize(), especially whencolor=False.This patch removes the early
_set_color(color)callin __init__and insteadstores the value in
self._color. The actual color initialization is nowperformed only once in
_get_formatter(), preserving existing behavior whileavoiding duplicate work.
A NEWS entry for gh-141571 has been added.