gh-139914: Fix another stack assert on HP-PA #142158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
changed the title
stefanor
commented
Dec 1, 2025
Python/ceval.c
Outdated
| assert(base < top); | ||
| assert((top - base) >= _PyOS_MIN_STACK_SIZE); | ||
| #else | ||
| assert(base <= top); |
Contributor
Author
There was a problem hiding this comment.
Sorry, that's bogus.
We were seeing:
_freeze_module: ../Python/ceval.c:498: tstate_set_stack: Assertion base < top' failed.`
But there must be more to that, because that assert was obviously correct.
Contributor
Author
There was a problem hiding this comment.
Fixed the commit to what I think should be correct.
Let me just try to reproduce the problem on the 3.14 branch...
Missed in pythonGH-139914, as it was introduced around the same time and is only relevant to pydebug builds.
Contributor
Author
|
Sorry, don't know what I was thinking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed in GH-139914, as it was introduced around the same time and is only relevant to pydebug builds.