gh-142349: Implement PEP 810 #142351
Open
gh-142349: Implement PEP 810 #142351
+5,083
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on bad usage of lazy
Highlight lazy imports in the new REPL
|
All commit authors signed the Contributor License Agreement. |
* Update example to add missing import * Add link to lazy keyword * Update documentation
* PEP-7 for import.c * re-order imports * fix tests * some final nits * alter other file * alter sysmodule.c
…ces, and prefer using `//` for comments instead of `/* */`.
hugovk
reviewed
Dec 17, 2025
…ariable names in lazy_import_new
Remove `get_lazy_modules` from docs
| .. c:function:: int PyImport_SetLazyImportsMode(PyImport_LazyImportsMode mode) | ||
| Similar to :c:func:`PyImport_ImportModuleAttr`, but names are UTF-8 encoded |
Member
There was a problem hiding this comment.
Copy-paste error? This seems unrelated to the function being described.
|
|
||
| print('json' in sys.modules) # True - now loaded | ||
|
|
||
| If an error occurs during module loading (such as :exc:`ImportError` or |
Member
There was a problem hiding this comment.
Perhaps also document that ImportCycleError may be raised?
| 1 LOAD_SMALL_INT 0 | ||
| LOAD_CONST 1 (('*',)) | ||
| IMPORT_NAME 0 (math) | ||
| IMPORT_NAME 2 (math + eager) |
Member
There was a problem hiding this comment.
Consider adding more tests for the new logic in dis.py.
| try: | ||
| lazy import os | ||
| except: | ||
| pass |
Member
There was a problem hiding this comment.
What about putting it in the except:?
lazy import within an except block. Also removed unused var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--142351.org.readthedocs.build/