Skip to content

Conversation

@sir-sigurd
Copy link
Contributor

I'd attribute this to the old issue, but for some reason, some developers seem to be annoyed by using old issues.

@sir-sigurd
Copy link
Contributor Author

Should we leave this for compatibility?

cpython/Include/pyport.h

Lines 73 to 78 in 132acab

#define PY_UINT32_T uint32_t
#define PY_UINT64_T uint64_t
/* Signed variants of the above */
#define PY_INT32_T int32_t
#define PY_INT64_T int64_t

/* 64bit platforms with unsigned int64 */
typedef PY_UINT64_T UINT64;
typedef unsigned char UINT8;
typedef uint64_t UINT64;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we can remove these typedefs and restore the original ones?

#if NOT_PYTHON
typedef unsigned char UINT8;
/* typedef unsigned long long int UINT64; */
#endif

@ammaraskar ammaraskar added the type-feature A feature request or enhancement label Sep 3, 2019
@csabella
Copy link
Contributor

I'd attribute this to the old issue, but for some reason, some developers seem to be annoyed by using old issues.

You can always open a new issue and then reference the old issue in the description. :-)

@sir-sigurd
Copy link
Contributor Author

sir-sigurd commented May 10, 2020

Closing this as the same changes were committed in 1a1bd2e which for some reason is attributed to bpo-40302 🤷‍♂️ .

@sir-sigurd sir-sigurd closed this May 10, 2020
@sir-sigurd sir-sigurd deleted the use-stdint branch May 11, 2020 05:56
@vstinner
Copy link
Member

vstinner commented May 11, 2020

Closing this as the same changes were committed in 1a1bd2e which for some reason is attributed to bpo-40302 man_shrugging .

It's just that I noticed a few remainaing PY_INT64_T types while working on https://bugs.python.org/issue40302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants