bpo-38311: Avoid sqlite3_enable_shared_cache deprecation warning when building with the macOS system SQLite3 #16469
Conversation
sqlite shared cached is disabled since the 10.7 release (2011).
devnexen
changed the title
|
no news |
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
Thanks for the PR. Unfortunately as noted, i'm not sure this is worth trying to fix. But if you want to take another stab at it, we can review it.
| Checks if a string contains a complete SQL statement. Non-standard."); | ||
|
|
||
| #ifdef HAVE_SHARED_CACHE | ||
| #if defined(HAVE_SHARED_CACHE) && !defined(__APPLE__) |
There was a problem hiding this comment.
This test is not sufficient because it will prevent _sqlite from being built with a local copy of SQLite rather than the Apple-supplied system version and that is something that many distributors of Python on macOS do, including the python.org macOS installers. So, to avoid the deprecation warning, you want to be able to know you are linking with the system version. That might be a little tricky to do reliably; it might have to be done in either configure.ac or setup.py and would need to take into account SDKs. And in most cases it is probably better to avoid using the macOS system SQLite anyway. So i'm not sure this is worth trying to fix.
There was a problem hiding this comment.
To be more precise, it would not prevent _sqlite from being built; it would disallow use of enable_shared_cache. Which, BTW, doesn't seem to be documented in the sqlite3 module doc page?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
ned-deily
changed the title
|
No problems I understand your reasons, thanks. |
4 participants
sqlite shared cached is disabled since the 10.7 release (2011).
https://bugs.python.org/issue38311