bpo-36670, regrtest: Fix WindowsLoadTracker sampling rate #16555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regrtest WindowsLoadTracker: the LOAD_FACTOR_1 constant has been computed for a sampling rate of 5 seconds.
ammaraskar
approved these changes
Oct 3, 2019
Member
ammaraskar
left a comment
ammaraskar
left a comment
There was a problem hiding this comment.
LGTM with either increasing the sampling interval or using the new 1s constant.
| # Exponential damping factor (see below) | ||
| # Seconds per measurement | ||
| SAMPLING_INTERVAL = 5 | ||
| # Exponential damping factor for a sampling interval of 5 seconds (see below) |
Member
There was a problem hiding this comment.
Thanks for the comment, I should have had this in here originally. I think it might be worth adding a little explanation like:
# Calculated using 1/exp(5sec/1min) = 1/exp(5/60)the source is https://github.com/torvalds/linux/blob/master/include/linux/sched/loadavg.h#L21
If you feel like 1 second is better, then the new constant would be 0.98347145382161748947374 https://www.wolframalpha.com/input/?i=1%2Fexp%281%2F60%29
Member
Author
|
I merged PR #16556 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regrtest WindowsLoadTracker: the LOAD_FACTOR_1 constant has been
computed for a sampling rate of 5 seconds.
https://bugs.python.org/issue36670