bpo-25720: curses: Fix check for whether WINDOW is a pad #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WINDOW_HAS_FLAGS will be defined by the configure check, but if the platform has ncurses.h, defines the macro always. Therefore, codes that check directly the field of WINDOW are enabled regardless of NCURSES_OPAQUE (since ncurses 5.7), and a platform that WINDOW is actually opaque occurs compile error at that place. For this reason, the codes are modified to use py_is_pad macro to check WINDOW state. Note that if ncurses doesn't have both is_pad function (since 5.8) and _flags field of WINDOW, there is no method to check whether WINDOW is a pad. In this case, NCURSES_OPAQUE is defined as zero to make WINDOW to non-opaque type before including ncurses.h.
Contributor
Author
|
Close this PR because I rewrote #4164 to improve the is_pad configure check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights of change
is_padfunction/macro.py_is_padmacro ifHAVE_CURSES_IS_PADorWINDOW_HAS_FLAGSare defined.WINDOW_HAS_FLAGSwithpy_is_padWINDOW_HAS_FLAGSwhen having ncurses.h.WINDOWto non-opaque type if bothHAVE_CURSES_IS_PADandWINDOW_HAS_FLAGSaren't defined when having ncurses.h.Motivation
WINDOW_HAS_FLAGSwill be defined by the configure check, but if the platform has ncurses.h, defines the macro always. Therefore, codes that check directly the field ofWINDOWare enabled regardless ofNCURSES_OPAQUE(since ncurses 5.7), and a platform thatWINDOWis actually opaque occurs compile error at that place.For this reason, the codes are modified to use
py_is_padmacro to checkWINDOWstate. Note that if ncurses doesn't have bothis_padfunction (since 5.8) and_flagsfield ofWINDOW, there is no method to check whetherWINDOWis a pad. In this case,NCURSES_OPAQUEis defined as zero to makeWINDOWto non-opaque type before including ncurses.h.https://bugs.python.org/issue25720