[WIP] bpo-38546: Add support.get_child_processes() #17640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libregrtest runtest() now checks if the test leaks direct child process running in the background.
ncoghlan
approved these changes
Dec 18, 2019
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
LGTM! One key point is that it fails gracefully on systems without /proc
Member
Author
|
I failed to prove that this PR helps to detect leaked processes. I prefer to not merge it until I managed to prove that it's useful. In the meanwhile, there are already existing checks which should detect some cases. See https://pythondev.readthedocs.io/unstable_tests.html for my notes on unstable tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libregrtest runtest() now checks if the test leaks direct child
process running in the background.
https://bugs.python.org/issue38546