Skip to content

bpo-40014: Skip os.getgrouplist related test if OSError is raised. #19075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
corona10 wants to merge 5 commits into from
Closed

bpo-40014: Skip os.getgrouplist related test if OSError is raised. #19075

corona10 wants to merge 5 commits into from

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Mar 19, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner March 19, 2020 16:22
@corona10 corona10 changed the title bpo-40014: Skip adding os.getgrouplist info if error is raised bpo-40014: Skip adding os.getgrouplist info if error is raised. Mar 19, 2020
@corona10 corona10 changed the title bpo-40014: Skip adding os.getgrouplist info if error is raised. bpo-40014: Skip os.getgrouplist related test if OSError is raised. Mar 19, 2020
vstinner
vstinner reviewed Mar 19, 2020
View reviewed changes
@corona10 corona10 requested a review from vstinner March 19, 2020 22:45
@corona10
Copy link
Member Author

corona10 commented Mar 19, 2020

@vstinner
Thanks for the review.
I 've updated the test to skip only for the known issue on darwin.
And it should raise the error if the platform is not darwin, because it can be a regression.

@corona10 corona10 closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot