Skip to content

bpo-40387: Fix example code for Queue.join #19713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sblancov wants to merge 1 commit into from
Closed

bpo-40387: Fix example code for Queue.join #19713

sblancov wants to merge 1 commit into from

Conversation

@sblancov
Copy link

@sblancov sblancov commented Apr 25, 2020 •
edited
Loading

@sblancov sblancov requested a review from rhettinger as a code owner April 25, 2020 14:48
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Apr 25, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@sblancov

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 25, 2020
remilapeyre
remilapeyre reviewed Apr 25, 2020
View reviewed changes
Doc/library/queue.rst
threads.append(t)
thread = threading.Thread(target=worker)
thread.start()
threads.append(thread)
Copy link

@remilapeyre remilapeyre Apr 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better as a loop comprehension?

@rhettinger rhettinger self-assigned this Apr 26, 2020
@rhettinger
Copy link
Contributor

rhettinger commented Apr 26, 2020

Sorry, I don't find this to be an improvement.

@rhettinger rhettinger closed this Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

1 more reviewer

@remilapeyre remilapeyre remilapeyre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rhettinger rhettinger

Labels

awaiting review docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sblancov @the-knights-who-say-ni @rhettinger @remilapeyre @bedevere-bot