Skip to content

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jun 4, 2020

Add a new test.support.filesystem_helper submodule and move TESTFN to filesystem_helper.

https://bugs.python.org/issue40275

@shihai1991
Copy link
Member Author

@vstinner Hi, victor. Pls take a look if you have free time, thanks.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I cannot review a PR modifying 100+ files. You may try to add a new submodule which first adds aliases to support symbols, create small PRs to update tests (ex: PR for 20 tests), and then really move symbols from support to the new submodule.

I mean something like that for support/filesystem_helper.py:

from test.support import TESTFN

I expect the first PR to only modify 3 files: support/__init__.py, the new submodule and test.rst.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@shihai1991
Copy link
Member Author

Sorry, I cannot review a PR modifying 100+ files. You may try to add a new submodule which first adds aliases to support symbols, create small PRs to update tests (ex: PR for 20 tests), and then really move symbols from support to the new submodule.

I mean something like that for support/filesystem_helper.py:

from test.support import TESTFN

I expect the first PR to only modify 3 files: support/__init__.py, the new submodule and test.rst.

Thanks for your suggestion, victor. I will update this PR.

@vstinner
Copy link
Member

vstinner commented Jun 4, 2020

Thanks for your suggestion, victor. I will update this PR.

I close this PR which has way too many reviewers.

@vstinner vstinner closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants