-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-40275: Adding filesystem_helper submodule in test.support #20625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40275: Adding filesystem_helper submodule in test.support #20625
Conversation
|
@vstinner Hi, victor. Pls take a look if you have free time, thanks. |
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I cannot review a PR modifying 100+ files. You may try to add a new submodule which first adds aliases to support symbols, create small PRs to update tests (ex: PR for 20 tests), and then really move symbols from support to the new submodule.
I mean something like that for support/filesystem_helper.py:
from test.support import TESTFN
I expect the first PR to only modify 3 files: support/__init__.py, the new submodule and test.rst.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thanks for your suggestion, victor. I will update this PR. |
I close this PR which has way too many reviewers. |
Add a new test.support.filesystem_helper submodule and move TESTFN to filesystem_helper.
https://bugs.python.org/issue40275