Skip to content

Conversation

@Yash-Singh1
Copy link

@Yash-Singh1 Yash-Singh1 commented Nov 14, 2020

Summary

Registered in browsh inside webbrowser module

Overview

Browsh is a terminal-based browser that runs based on headless firefox. Here is the documentation link for more: https://www.brow.sh/

The webbrowser module is:

Interfaces for launching and remotely controlling Web browsers.

According to a comment at the top of the file.
They have many default registered terminal browsers including lynx and w3m. This PR adds on to that list by adding in the browsh browser using the startup-url flag:

--startup-url string URL to launch at startup (default "https://www.brow.sh")

I also added in browsh inside the Docs for webbrowser

Links

The link to the issue: https://bugs.python.org/issue42330
The link to the webbrowser documentation: https://docs.python.org/3/library/webbrowser.html
The browsh documentation: https://www.brow.sh/
The Github Repo for Browsh: https://github.com/browsh-org/browsh

https://bugs.python.org/issue42330

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Yash-Singh1

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@terryjreedy
Copy link
Member

Sorry, we are not going to add this.

@Yash-Singh1 Yash-Singh1 deleted the patch-1 branch November 15, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants