bpo-41559: Convert lists to tuples in genericalias to prepare for PEP 612 #24056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZackerySpytz
reviewed
Jan 5, 2021
Member
Author
|
@ZackerySpytz Thank you for taking the time to review this and for raising many glaring points :). I'm quite busy right now so I'll try to address them by this weekend. |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
Author
|
Closed in favour of #25449 which uses a pure Python version of PEP 612. Thus we won't need a C implementation any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs manual backport to 3.9.
https://bugs.python.org/issue41559