-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-17942: Improve IDLE debugger user interface #2454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@roseman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @ned-deily to be potential reviewers. |
|
Turn Debugger on, Run file, and |
terryjreedy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See posted error
|
Thanks Terry. I've added the missing routine to filelist.py in my branch. It looks like this is automatically added to this pull request...? (excuse the newbie question) |
|
Yes, when one pushes a commit to a branch on a github repository that is the basis for a pull request, then the commit appears on the pull request. You probably pushed to 'origin'. If I created a local pr_2454 branch and made some commits, and did 'git push https://github.com/roseman pr_2454:debugger-ui-17942', those commits would become part of this. Please ask questions. The devguide is both helpful and confusing. |
|
To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request. If/when the requested changes have been made, please leave a comment that says, |
|
From AppVeyor Add 'r' prefix to regex |
|
replaced by newer PR |
Previous versions were dependent on a parallel 'ui' library that handled some of the 8.4/8.5 differences in Tk, as well as provided some utilities. In terms of functionality, this version omits the tooltips found in the original one (code left but commented out to indicate where they'd go), but otherwise is the same. Some pieces, e.g. context menu bindings, windowing system calls, etc. should probably still be pulled into a separate ui module.
https://bugs.python.org/issue17942