Skip to content

bpo-43362: Fix bad free in py_sha3_new_impl function #24702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexhenrie wants to merge 1 commit into from
Closed

bpo-43362: Fix bad free in py_sha3_new_impl function #24702

alexhenrie wants to merge 1 commit into from

Conversation

@alexhenrie
Copy link
Contributor

@alexhenrie alexhenrie commented Mar 2, 2021 •
edited by bedevere-bot
Loading

Initializing buf.obj to NULL earlier in the function prevents the possibility of PyBuffer_Release being called on an invalid object.

https://bugs.python.org/issue43362

@alexhenrie alexhenrie requested a review from tiran as a code owner March 2, 2021 02:52
auvipy
auvipy suggested changes Mar 3, 2021
View reviewed changes
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check function declaration isn’t a prototype [-Wstrict-prototypes]? also doesn't this need some change in tests?

@github-actions
Copy link

github-actions bot commented Apr 3, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 3, 2021
@tiran tiran removed skip news stale Stale PR or inactive for long period of time. labels Apr 17, 2021
@tiran
Copy link
Member

tiran commented Apr 17, 2021

Please rebase the PR and provide a blurb (news entry).

tiran
tiran requested changes Apr 17, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the PR and provide a blurb (news entry).

@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tiran
Copy link
Member

tiran commented Apr 17, 2021

I have found another potential problem and opened #25463. You are mentioned as co-author. Thanks for your assistance!

@tiran tiran closed this Apr 17, 2021
@alexhenrie
Copy link
Contributor Author

alexhenrie commented May 6, 2021

@tiran Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran requested changes

+1 more reviewer

@auvipy auvipy auvipy requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alexhenrie @tiran @bedevere-bot @auvipy @corona10 @the-knights-who-say-ni