Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

(cherry picked from commit b4baace)

@serhiy-storchaka serhiy-storchaka added the tests Tests in the Lib/test dir label Jul 10, 2017
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, the test fails on my Windows VM:

AttributeError: module 'package' has no attribute 'submodule'

If I modify the test to only run 1 loop iteration, the test pass, but fail if run again... It fails randomly.

Please don't add such test to 3.5 yet :-)

@vstinner
Copy link
Member

Hum, I forgot to explain how I tested: I downloaded this PR in my 3.5 checkout of CPython on Windows, and ran the test using "python -m test -m test_concurrency -v test_import".

@serhiy-storchaka
Copy link
Member Author

Thanks for testing on Windows @Haypo. Now we know that the bug exposed in bpo-30891 exists on 3.5.

@larryhastings
Copy link
Contributor

Just a reminder: I expect to tag 3.5.4rc1 in eleven or twelve hours. If this is a bugfix (not a security fix), and it isn't merged by then, it will probably never be merged into 3.5.

@serhiy-storchaka
Copy link
Member Author

Since Victor's fix was not backported, the test can't be added.

@vstinner
Copy link
Member

Yeah, I agree that it's too late in the 3.5 cycle (moving to security-only fixes) for work on such old importlib bug.

@serhiy-storchaka serhiy-storchaka deleted the backport-b4baace-3.5 branch August 9, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants