Skip to content

Conversation

@Naman-Bhalla
Copy link

@Naman-Bhalla Naman-Bhalla commented Jul 12, 2017

The fix proposes to add a check for en_US.iso88591 in test_localeflag. This should fix test_re for languages like en_IN till another fix is done, which is requiring a lot of code.
The error for en_IN locale and some others can also be found here :- https://hastebin.com/ecabuvovuj.sql

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Naman-Bhalla Naman-Bhalla changed the title bpo:29571 - test needs en_US.iso88591 locale in test_localeflag bpo-29571 - test needs en_US.iso88591 locale in test_localeflag Jul 12, 2017
@Naman-Bhalla Naman-Bhalla changed the title bpo-29571 - test needs en_US.iso88591 locale in test_localeflag bpo-29571 - test_re needs en_US.iso88591 locale check in test_locale_flag() Jul 12, 2017
@serhiy-storchaka
Copy link
Member

This doesn't fix the issue.

  1. Locale-depending regular expressions work only with 8-bit encodings. UTF-8 is not supported.
  2. en_US.iso88591 is not particularly interesting for testing. And it may be not supported on Windows.
  3. This patch changes program global locale. This affects all following tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants