Skip to content

Conversation

@musically-ut
Copy link
Contributor

@musically-ut musically-ut commented Jul 22, 2017

Only C implementation was tested..
(cherry picked from commit 287c559)

https://bugs.python.org/issue30822

…honGH-2783)

Only C implementation was tested..
(cherry picked from commit 287c559)
@larryhastings
Copy link
Contributor

Just a reminder: I expect to tag 3.5.4rc1 in eleven or twelve hours. If this is a bugfix (not a security fix), and it isn't merged by then, it will probably never be merged into 3.5.

@musically-ut
Copy link
Contributor Author

musically-ut commented Jul 22, 2017

This is a relatively minor bugfix (just fixes an export _divide_and_round which shouldn't have happened and re-enables some tests which are not visible to the end-user anyway).

So not much to be gained but maybe something to be lost (there is a faint possibility of some code out there using that removed export).

@vstinner
Copy link
Member

@larryhastings: "Just a reminder: I expect to tag 3.5.4rc1 in eleven or twelve hours. If this is a bugfix (not a security fix), and it isn't merged by then, it will probably never be merged into 3.5."

Sorry @musically-ut, we missed the deadline. The problem is not enabling tests. If tests start to fail, it will be harder to justify to apply bugfixes in the 3.5 branch. Let's focus on 2.7, 3.6 and master branches ;-)

@vstinner vstinner closed this Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants