Skip to content

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Sep 28, 2021

This should give us the default we normally want, "on", without disrupting contributors too much. This should be a good-enough place to start. We can adjust the heuristic (e.g. PGO or running-in-source-tree) later if needed.

https://bugs.python.org/issue45020

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 60b8694 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 28, 2021
@ericsnowcurrently
Copy link
Member Author

ericsnowcurrently commented Sep 28, 2021

3 buildbots failed, all non-debug, all with the same failure in idlelib.idle_test.test_help_about.LiveDialogTest.test_printer_buttons (name='license'):

This matches the failures on the Windows checks (which are also non-debug).

@gvanrossum
Copy link
Member

Looks like something is finding a data file (some license) by using __file__?

@ericsnowcurrently
Copy link
Member Author

I prefer gh-28940, so I'm tabling this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants