bpo-45979: Fix Tkinter tests with old Tk #29913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Tkinter tests are now passed on Linux with Tk versions 8.5.4 to 8.5.19 and 8.6.0 to 8.6.12.
serhiy-storchaka
added
tests
E-Paine
reviewed
Dec 6, 2021
| w.wm_attributes("-type", "dialog") | ||
| try: | ||
| w.wm_attributes("-type", "dialog") | ||
| except TclError: |
Contributor
There was a problem hiding this comment.
Rather than catching an error, would we be better checking for supported Tk version like you've done elsewhere? (if get_tk_patchlevel() >= (8, 5, 9):)
Member
Author
There was a problem hiding this comment.
There is no get_tk_patchlevel() in the tkinter module. It is only defined in tests.
serhiy-storchaka
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 283f1eb 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Tkinter tests are now passed on Linux with Tk versions
8.5.4 to 8.5.19 and 8.6.0 to 8.6.12.
https://bugs.python.org/issue45979