Skip to content

Conversation

@USLTD
Copy link

@USLTD USLTD commented Jan 13, 2022

Partially added type hints and instead of wildcard importing import only needed parts

Partially added type hints and instead of wildcard importing import only needed parts
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@UltraStudioLTD

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@AlexWaygood
Copy link
Member

Hi, and welcome to CPython!

It's not really clear to me what this PR addresses, I'm afraid — you haven't really stated what problems there are with the existing module that your PR is trying to solve. Please also note that type hints are very rarely added to the standard library — if you want to help work on type hints, I'd recommend heading over to https://github.com/python/typeshed, where PRs are very welcome 😀

I'm afraid there are some other issues with this PR, too. For the CPython repo, almost every PR (unless it's doing something extremely trivial, like fixing a documentation typo) should be linked to an issue ticket on bugs.python.org. Lastly, and most importantly, you're unfortunately attempting to merge this PR into the 3.10 branch. For CPython, almost all changes are first made to the main branch (which currently represents the as-yet-unreleased Python 3.11), and then backported to maintenance branches if necessary. In order to have your ideas considered, you would have to close this PR and file a new one against the main branch.

@USLTD USLTD closed this Jan 13, 2022
@USLTD USLTD deleted the patch-1 branch February 2, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants