Skip to content

bpo-30830: test_logging: don't use daemon threads #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner wants to merge 3 commits into from
Closed

bpo-30830: test_logging: don't use daemon threads #3135

vstinner wants to merge 3 commits into from

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Aug 18, 2017 •
edited by bedevere-bot
Loading

test_logging:

  • Don't use daemon threads, but regular threads
  • Replace hardcoded literal constants with a new STOP_TIMEOUT
    constant.
  • Fix servers: don't call fail() since the method doesn't exist, but
    raise directly an AssertionError

https://bugs.python.org/issue30830

@vstinner
bpo-30830: test_logging: don't use daemon threads
38ff03b 
test_logging:

* Don't use daemon threads, but regular threads
* Replace hardcoded literal constants with a new STOP_TIMEOUT
  constant.
* Fix servers: don't call fail() since the method doesn't exist, but
  raise directly an AssertionError
@vstinner
Copy link
Member Author

vstinner commented Aug 18, 2017

Abandonned, replaced by my PR #3137.

@vstinner vstinner closed this Aug 18, 2017
@vstinner vstinner deleted the logging_stop branch August 18, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @Mariatta @the-knights-who-say-ni @bedevere-bot