[3.6] bpo-31238: pydoc ServerThread.stop() clears ref cycle #3177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServerThread.stop() now explicitly sets its docserver attribute to None to break a reference cycle.
Member
Author
|
For Python 3.6, I chose to not joins the thread as I did in master (PR #3151) since I'm not 100% confident that join() doesn't block too long. |
Member
Author
|
@pitrou: What do you think of joining or not the thread in Python 3.6? |
Member
|
It's not really a bugfix, so you should leave it alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerThread.stop() now explicitly sets its docserver attribute to
None to break a reference cycle.
https://bugs.python.org/issue31238