Skip to content

Conversation

@abenkovskii
Copy link

@abenkovskii abenkovskii commented Aug 22, 2017

codeop.compile_command actually accepts symbol="exec" too

https://bugs.python.org/issue737999

codeop.compile_command actually accepts symbol="exec" too
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@abenkovskii abenkovskii changed the title Fix codeop.compile_command docstring bpo-737999 Fix codeop.compile_command docstring Aug 22, 2017
@merwok
Copy link
Member

merwok commented Sep 20, 2017

Hello! I can’t review right now, but wanted to say you might get more attention by opening a new doc bug instead of recycling an old ticket that’s already closed.

Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Éric. @abenkovskii could you please open a new issue? bpo-737999 was closed 14 years ago so it would be better to discuss your ptahc in a new issue.

Also, we don't need a NEWS entry for this.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner
Copy link
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@JulienPalard
Copy link
Member

@abenkovskii I agree with Berker, could you please open a new issue and remove the NEWS entry?

@csabella
Copy link
Contributor

Closing as there hasn't been any response to multiple requests for a bug report to be opened. Please feel free to re-open this PR or create a new one to address the existing comments. Thanks!

@csabella csabella closed this Nov 20, 2019
@merwok
Copy link
Member

merwok commented Nov 20, 2019

@csabella Would you mind creating a doc ticket for this?

@csabella
Copy link
Contributor

Created issue 38872.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants