bpo-31217: Fix regrtest -R for small integer #3258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround a complex bug in regrtest when hunting reference leaks. Add a maybe_small_long() function to try to get int singletons to prevent false alarm on memory block leaks.
pitrou
reviewed
Sep 1, 2017
| # bpo-31217: On CPython, x_sub() of longobject.c doesn't try to use int | ||
| # singletons. Try to get singletons to prevent false alarms on memory block | ||
| # leaks. | ||
| return int(str(x)) |
Member
There was a problem hiding this comment.
Rather than rely on small int singletons, I think an explicit pool would be less implementation-dependent.
Member
Author
|
Abandonned in favor of the PR #3260. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround a complex bug in regrtest when hunting reference leaks.
Add a maybe_small_long() function to try to get int singletons to
prevent false alarm on memory block leaks.
https://bugs.python.org/issue31217