bpo-31701: faulthandler.enable() registers exc handler as last #3928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpo-31701: On Windows, faulthandler.enable() now registers the exception handler as the last handler to be called, rather than the first to be called. It prevents handled C++ exceptions to be logged by faulthandler.
vstinner
changed the title
vstinner
changed the title
Member
Author
|
Oops, my PR doesn't work as expected. |
Member
Author
|
I misunderstood how Windows works. UNIX signals handlers and Windows exception handlers are unrelated. Exception handlers are not called to handle a SIGSEGV signal. |
Member
Author
|
I tested this PR with a C++ exception: the change has no effect, the exception is still logged by faulthandler. So I abandon this useless change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-31701: On Windows, faulthandler.enable() now registers the
exception handler as the last handler to be called, rather than the
first to be called. It prevents handled C++ exceptions to be logged
by faulthandler.
https://bugs.python.org/issue31701