[2.7] bpo-31829: Resolve some portability issues with pickle. #4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
force-pushed
the
pickle-binary-2.7
branch
from
7f740e1 to
2c16aea
Compare
serhiy-storchaka
changed the title
serhiy-storchaka
changed the title
* Document that files should be open in binary mode even for protocol 0 for portability. * Raise a ValueError when pickle with binary protocol to a file opened in text mode on Windows. * Emit a deprecation warning when pickle with binary protocol to a file opened in text mode on Unix. * Emit a deprecation warning in Py3k mode when pickle with protocol 0 to a file opened in text mode. * Fixed unpickling on Unix or in binary mode files writen in text mode on Windows. RuntimeWarning now is emitted in cases that was not unpickleable before. Files containing Unicode strings will be unpickled incorrectly. * `\r`, `\0` and `\x1a` (end-of-file on Windows) now are escaped in Unicode strings in protocol 0.
serhiy-storchaka
force-pushed
the
pickle-binary-2.7
branch
from
031af8b to
fb4e85c
Compare
Contributor
|
Ping, @serhiy-storchaka? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
portability.
text mode on Windows.
opened in text mode on Unix.
a file opened in text mode.
Fixed unpickling on Unix or in binary mode files writen in text mode onWindows. RuntimeWarning now is emitted in cases that was not unpickleable
before.
Files containing Unicode strings will be unpickled incorrectly.\r,\0and\x1a(end-of-file on Windows) now are escaped inUnicode strings in protocol 0.
https://bugs.python.org/issue31829