Skip to content

Conversation

@vwvw
Copy link

@vwvw vwvw commented Nov 15, 2017

@vwvw vwvw requested a review from 1st1 as a code owner November 15, 2017 13:12
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@vwvw
Copy link
Author

vwvw commented Nov 15, 2017

CLA should be signed: https://bugs.python.org/user27283

Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a unittest.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vwvw
Copy link
Author

vwvw commented Nov 15, 2017

Fix isn't so simple. Closing pull request for now.

@vwvw vwvw closed this Nov 15, 2017
@vwvw vwvw deleted the fix-issue-32034 branch November 15, 2017 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants