bpo-32657 Removing mutable entry from send_message

[chason]

The signature for send_message included mutable defaults for two sets of
options, mail_options and rcpt_options. Additionally, the default for
rcpt_options was a dictionary, not a list. These have now been changed
to have a default of None, which is set to a dictionary during function
execution.

https://bugs.python.org/issue32657

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

[chason]

I also have a test written for this, but it requires the changes from #5314 to work properly

[bitdancer]

Removed

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[chason]

I have made the requested changes; please review again

[bedevere-bot]

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

[csabella]

The smtplib docs page needs to be updated to reflect the changes.

[matrixise]

Hi @chason, good catch from @csabella , you have to update the documentation, after that, we will continue to review your PR. Have a nice day,

[chason]

Hi @matrixise I added that documentation change after @csabella noted it. Thanks.

[chason]

Hi guys, I know everyone is busy but I was hoping someone had a time to review this!

[methane]

I think this is fixed by #8554.