Skip to content

Conversation

@jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented May 14, 2018

@jdemeyer jdemeyer changed the title bpo-5755: don't compile extensions with -Wstrict-prototypes bpo-5755: remove compiler flag -Wstrict-prototypes May 15, 2018
@jdemeyer
Copy link
Contributor Author

jdemeyer commented May 15, 2018

CC @grimreaper

@grimreaper
Copy link
Contributor

Strict Prototypes is correct and helpful for C. That said, the way it is currently implemented, by checking for the compiler in CC is sub-optimal at best.
CC ought to always be a C compiler, and never a C++ compiler.
It also seems questionable that distutils is using the python cflags rather than a dedicated set.

Please also remove OPT="$OPT $STRICT_PROTO" and any other reference to STRICT_PROTO since it is now unused.

TL;DR; +1 to this change; distutils should be fixed to not use python's CFLAGS; we should re-add strict-prototypes to CFLAGS when distutils is fixed.

@methane
Copy link
Member

methane commented Jun 6, 2018

PR-7395 was merged, and backported to 3.7 and 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants