-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-33698: Fixed skipping of empty paths while reading pth [WIP].
#7243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
pth.pth.
pth.pth.
|
This patch changes the documented |
zooba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is incorrect and should not be merged.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
pth.pth [WIP].
|
Please continue discussion on the bug (which will remain closed) so we can help figure out what you need and provide better alternatives. |
pth [WIP].pth [WIP].
|
@csabella, do you really mean to highlight me? |
|
@VadimPushtaev, thank you for asking. I apologize for my error. Not sure how I picked your name instead of the creator of the pull request. |
This patch fixes possibility to use imports from script directory.
--Follow up to Issue 29326.
Alexey erroneously broke adding empty paths to
sys.pathalong with his fix of'\n'insys.path.--Official embeddable Python distributions do contain a blank line in its
._pth, and that previously allowed users to import modules from script directory.https://bugs.python.org/issue29326