Skip to content

Conversation

@excitoon
Copy link

@excitoon excitoon commented May 30, 2018

This patch fixes possibility to use imports from script directory.

--Follow up to Issue 29326.

Alexey erroneously broke adding empty paths to sys.path along with his fix of '\n' in sys.path.--

Official embeddable Python distributions do contain a blank line in its ._pth, and that previously allowed users to import modules from script directory.

https://bugs.python.org/issue29326

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@excitoon excitoon changed the title Issue 29326: Fixed skipping of empty paths while reading pth. Issue #29326: Fixed skipping of empty paths while reading pth. May 30, 2018
@excitoon excitoon changed the title Issue #29326: Fixed skipping of empty paths while reading pth. bpo-29326: Fixed skipping of empty paths while reading pth. May 30, 2018
@izbyshev
Copy link
Contributor

This patch changes the documented ._pth behavior in backwards incompatible way. I'm not sure that we want to do that, but if we do, the documentation should be updated.

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is incorrect and should not be merged.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@excitoon excitoon changed the title bpo-29326: Fixed skipping of empty paths while reading pth. bpo-29326: Fixed skipping of empty paths while reading pth [WIP]. May 30, 2018
@zooba
Copy link
Member

zooba commented May 30, 2018

Please continue discussion on the bug (which will remain closed) so we can help figure out what you need and provide better alternatives.

@excitoon excitoon changed the title bpo-29326: Fixed skipping of empty paths while reading pth [WIP]. bpo-33698: Fixed skipping of empty paths while reading pth [WIP]. May 30, 2018
@csabella
Copy link
Contributor

csabella commented May 29, 2019

@excitoon, thank you for your suggestion for improving CPython. Based on @zooba's comment and the discussion on the bug tracker, I'm going to close this issue.

@csabella csabella closed this May 29, 2019
@VadimPushtaev
Copy link
Contributor

@csabella, do you really mean to highlight me?

@csabella
Copy link
Contributor

@VadimPushtaev, thank you for asking. I apologize for my error. Not sure how I picked your name instead of the creator of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants